Fix integrations not saving on Firefox
What does this MR do?
Context
When users want to setup third party integrations like Jira or Slack, they go to Project > Settings > Integrations (for example /gitlab-org/gitlab-shell/-/services/jira/edit) and need to fill in details in the integration form to activate it.
Issue
A recent bug report #292891 (closed) that saving of the above form did not work on Safari. While the report is for Jira and mentions group-level integrations, I was able to replicate it without setting up group-level integrations and it's not specific to Jira.
Solution
In this original issue #273270 (closed), we implemented a fix with !48975 (merged). However, while fixing the issue for Safari, this caused a regression #292891 (closed) in Firefox which prevented users from saving the form.
This MR reverts the original changes and implements an alternative fix for the original issue.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team