Skip to content

Extract custom value stream form fields

Ezekiel Kigbo requested to merge 267536-extract-custom-stage-fields into master

What does this MR do?

This MR is some ~"feature::maintenance" to simplify the implementation of #267536 (closed). We will still need the original form while we migrate to the new layout, but will need to use the same fields in the new form, so this MR allows us to reuse the form fields without breaking the existing form.

  • Extracts the form fields for custom value stream into a new component
  • Moves some related functionality into utils and constants
  • Replaces finders with data-testids

This MR will be followed up by:

Screenshots (strongly suggested)

No visual changes

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #267536 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading