Add MR information to the diff file IDs
What does this MR do?
For #17531 (closed)
The current ID assigned to diff files is only unique within an MR.
This change mixes the group/user, the project name, and the MR id into the Diff File ID.
Diff File IDs can now be guaranteed to be unique among ALL Diff Files.
Timeline
Merge Request | Description |
---|---|
!49173 (merged) !49174 (merged) !49190 (merged) !49208 (merged) |
Various cleanup merge requests in preparation for this feature. |
!49506 (merged) | Identify diff files using the content_sha
|
!50022 (merged) | Switch identification to use blob.id
|
!50033 (merged) | Add tooling to add/remove reviews from LocalStorage to accommodate the file review feature |
We're here |
Add the current merge request IID to the file ID |
Add UI to review files |
Screenshots (strongly suggested)
N/A, just increasing the uniqueness of IDs assigned to diff files.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph