Skip to content

Use Pipeline#can_store_security_reports? method to consolidate logic

Mehmet Emin INAC requested to merge 262038_use_can_store_security_reports into master

What does this MR do?

This MR changes the logic of deciding to store the security reports or not which consolidates the logic.

The Ci::Pipeline#can_store_security_reports? is already defined in the public interface of the model but I think it's better to keep the tests a bit detailed instead of just stubbing that method call.

Related to #262038 (closed).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mehmet Emin INAC

Merge request reports

Loading