Skip to content

Allow more actions on group members

Alex Kalderimis requested to merge ajk-group-member-policy-fix into master

What does this MR do?

This allows more actions on group members.

Specifically, we want to allow :read_group, without which certain policy checks will fail. Currently anonymous users are prevented from performing any action, which is excessively strict, when there are many actions an anonymous user can perform, such as reading group, and viewing group members.

This was implemented in support of !40088 (merged), but can be extracted in advance, and fixes a distinct bug.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

This MR changes authorization code for group-members. It will require a review by a @gitlab-com/gl-security/appsec team member.

Edited by Andrew Kelly

Merge request reports

Loading