Skip to content

Stablize register spec

Sanad Liaquat requested to merge qa-shl-fix-register-spec into master

What does this MR do?

Stablizes register spec by:

  1. Retrying the complete signup process (current retry mechanism was broken because if signup was expected to fail but succeeded, the retry would assume that we are on the register page and try to fill in the fields)
  2. Retry enable_require_admin_approval_after_user_signup_via_ui
  3. Give more time for require_admin_approval_after_user_signup to kick in.

Closes #294188 (closed)

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Sanad Liaquat

Merge request reports

Loading