Fix project access token regression
What does this MR do?
Resolves #296028 (closed) by fixing a regression introduced in !47247 (merged).
It modifies the authentication system to reintroduce the project_bot? check. Otherwise, JWTs would not be issued for bot users outside of a project scope (e.g. the container registry), like described in #296028 (closed).
Please use this MR only as template. I would suggest adding a regression test that detects the error that happened previously, and request a security review because I am unfamiliar with GitLab's auth system. However, no security review happened for !47247 (merged) and I am not sure which process to follow here. Effectively, this MR just reverts a change.
Please close the MR in favor of a new one if you decide to add a regression test. I can add changelog items if this MR is acceptable.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
This reverts a single line change. I do not believe any of the following points apply.
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team