Delete Elasticsearch migrations index in rake elastic:delete_index
What does this MR do?
The migrations Elasticsearch index was recently introduced but we didn't add anything to our normal lifecycle rake tasks to delete it. This should have been done initially and will be the expected user experience.
This task is also used by gitlab:elastic:index which is the main way
for resetting your index back to scratch. It makes sense that these all
will clear out all index types including the migrations index. This will
help with any users trying to use this rake task to do a reset of
everything and will also help with local development.
This MR also makes 2 minor refactors to introduce methods
#delete_migrations_index and #migrations_index_exists? which should
simplify a lot of duplicated calls. Most of the changes in this MR is
refactoring to use these new helper methods.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team