Drop group_id from compliance_management_frameworks table
What does this MR do?
- As part of the work to create custom compliance framework labels, frameworks are now assigned to namespaces and not a single group.
-
group_id
was ignored in 13.6 and can now be deleted from the database. - This MR drops the column from the database. (Step 2 in the process to remove a column.)
database
Database ReviewMigrate
== 20210105103649 DeleteColumnGroupIdOnComplianceFramework: migrating =========
-- remove_column(:compliance_management_frameworks, :group_id, :bigint)
-> 0.0013s
== 20210105103649 DeleteColumnGroupIdOnComplianceFramework: migrated (0.0014s)
Rollback
== 20210105103649 DeleteColumnGroupIdOnComplianceFramework: reverting =========
-- add_column(:compliance_management_frameworks, :group_id, :bigint)
-> 0.0013s
== 20210105103649 DeleteColumnGroupIdOnComplianceFramework: reverted (0.0042s)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Woolf