Skip to content

Remove duplicated sidebar toggle when signed out

André Luís requested to merge andr3-remove-sidebar-toggle-reviewers into master

What does this MR do?

The right sidebar toggle button is showing up duplicated when the user is signed out.

This MR restores the original logic, even though it isn't great to begin with:

  • If signed in: toggle is displayed on ToDos
  • If signed out, ToDos don't show: toggle is displayed on the Assignees

Never on reviewers, but it was included when we duplicated the code.

Screenshots (strongly suggested)

When Before After
Signed out Before signed out Screenshot_2021-01-05_at_19.06.33
Signed in Screenshot_2021-01-05_at_19.06.13 Screenshot_2021-01-05_at_19.06.13

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Addresses #296658 (closed)

Edited by André Luís

Merge request reports

Loading