Skip to content

#36668 show not found for empty tag search result

renamoo requested to merge renamoo/gitlab:not-found-36668 into master

What does this MR do?

Change the message shown when user search the tags. (#36668 (closed))

Previous Behavior

  • When there are no tags, show "Repository has no tags yet"
  • When there are tags but user filter does not produce any result, show "Repository has no tags yet"

Fixed Behavior

  • When there are no tags, show "Repository has no tags yet"
  • When there are tags but user filter does not produce any result, show "No tags found for [search word]"

Screenshots (strongly suggested)

When there are no tags, it always shows "Repository has no tags yet" as previously スクリーンショット_2021-01-06_8.13.09

When there are tags but query returns an empty result, it shows "No tags found for [search word]" スクリーンショット_2021-01-06_8.12.58

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by renamoo

Merge request reports

Loading