Remove default value for udpate_sequence_id
What does this MR do?
It removes the default value for update_sequence_id in JiraConnect::SyncBranchWorker
and JiraConnect::SyncMergeRequestWorker
. This change allowes to make the workders idempotent.
This is the part 3 of a multi release effort to make JiraConnect workers idempotent.
The workers sync repository and merge request data with Jira. They send an API request containing a update_sequence_id
which is generated from a timestamp and helps Jira to avoid conflicts.
In my first attempt to make the workers idempotent, it was discovered that update_sequence_id
would change when the worker would run twice with the same argument and because of this wouldn't be idempotent. To fix this, update_sequence_id
needs to be generated outside the worker and provided as an argument.
Related issues
Realted MRs
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done