Skip to content

Add specs for nil project PAT authentication

What does this MR do?

Add specs to check that project access token authentication still works when project is nil.

Added ~"technical debt" label because a bug was introduced with !47247 (merged), causing the project policy to always return false for nil projects (which are valid). More bug explanation here: !47247 (comment 478690195)

The bug was fixed: !50800 (merged), and this MR introduces a spec that would have caught the bug in the first place. Verified that this spec fails with !47247 (merged) and passes with the bugfix changes made in !50800 (merged)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #296599 (closed), #296028 (closed), and #296563 (closed)

Edited by Serena Fang

Merge request reports

Loading