Refactor helper method to serializer [RUN AS-IF-FOSS]
What does this MR do?
In preparation for #281809 (closed) and as a follow-up to !40548 (merged) this MR refactors a helper method to use a serializer. This will allow us to use member_serializer
for group members and project members and is also a cleaner implementation.
frontend changes
Note aboutAll frontend changes are to change references of source.name
to source.fullName
. Originally the backend exposed the the source's (parent group) full_name
property as name
. But it didn't really make sense to alias full_name
as name
because we might need the actual name
property in the future. This MR removes that alias from the backend and changes the frontend to match.
Local testing
- Create a group
- Navigate to
Group
->Members
How to add a group
- Navigate to
Group
->Members
- Click the
Invite group
tab
How to add an invited member
- Navigate to
Group
->Members
- In the
GitLab member or Email address
enter an email that a user does not already own - Click
Invite "example@test.com" by email
How to request access to a project
- Log in (or impersonate) a user that doesn't already have access to the group
- Navigate to the group overview
- Click
Request access
located below the project name
Screenshots (strongly suggested)
No visual changes. Screenshots below for context:
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- Not needed, developer facing change
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team