Resolve "Provisoned Accounts - Welcome Email"
What does this MR do?
Consolidates two emails send to user after creating an account via SAML into one.
In class that creates user during group provisioning we call now skip_confirmation_notification! that stops Devise from sending typical confirmation email.
We also stop sending typical email about member added to group, instead we're sending one that combines adding to group and confirming account.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #276018 (closed)
Edited by Gosia Ksionek