Fix experiment user recording and "group type" mismatch
Fixes experiment user record_experiment_user
and experiment_enabled?
"group type" mismatch
- The
tracking_group
is calculated byrecord_experiment_user
is forcurrent_user
subject, whereas the one calculated by theexperiment_enabled?
is calculated for the cookie subject. - I will add tests after the proposal make sense
Related to #297379 (closed)
Affected experiments are any experiment doing the below with subject:
experiment_enabled?(:foo)
record_experiment_user(:foo)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alper Akgun