Attach tooltip to a wrapper in disabled buttons
What does this MR do?
This Merge Request fixes a bug with the new Tooltips API where tooltips with disabled buttons don‘t disappear in the blob viewer. This problem arises because BootstrapVue tooltips do not work on disabled elements unlike their Bootstrap counterpart.
To fix this problem, we have to address every case individually. Each disabled button should be wrapped in a span elements that has the tooltip attached. This Merge Request focuses on the blob button helpers and I will open other merge requests for HAML templates.
How to test?
- Enable the
gl_tooltipsfeature flag in your local environment. - Open the following URL:
http://localhost:3000/h5bp/html5-boilerplate/-/blob/57342272e6c2c74894c4d2fa56344044f4350e90/LICENSE.txt - You should see the Edit buttons disabled. If you hover over them, the tooltips should appear and dissapear when hovering out.
Screenshots (strongly suggested)
| Before | Ater |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team