Draft: Fix for setting `updated_at` on issues
What does this MR do?
This fixes the ability for users with permission to pass updated_at
to an Issue
and actually have it take effect. It solves two bugs at the same time (because solving one without the other means the problem isn't actually solved).
-
last_edited_at
wasn't followingupdated_at
when it should be set to the same value. -
Note
records were always updating theupdated_at
column for their parentnoteable
. This meant that as part of the#handle_changes
set of calls inIssues::UpdateService
,create_assignee_note(issue, old_assignees)
was then overriding theupdated_at
value we had previously set.
I don't believe system notes should be affecting the parent noteable
updated_at
field so this MR blocks that from happening.
Related #26534 (moved)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May