Convert RateLimit-Reset header format to Unix time
What does this MR do?
Closes gitlab-com/gl-infra/scalability#795 (closed)
In gitlab-com/gl-infra/scalability#731 (closed), new RateLimit-* headers are added into the response headers when a request is throttled. This initiative is to make the responses consistent between HAProxy and RackAttack. After the deployment, it turns out that the RateLimit-Reset header's format is different from the same header returned from HAProxy. There isn't a standard for this kind of header. The internet-drafted standard stated that we can use either format.
The RateLimit-Reset response header field indicates either
- the number of seconds until the quota resets, or
- the timestamp when the quota resets.When looking at other applications and services, Unix time is adopted more popularly. Plus, the HAProxy header was introduced long before. There maybe some consumers relying on this header format. Therefore, this MR is to convert its format to Unix time.
Screenshots (strongly suggested)
Before
After
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry. # Note: The headers are not yet released. This is a fix. So, I think this change doesn't need a changelog. -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team