Prevent user-defined variables from being used by non-maintainers
What does this MR do?
Related to #295234 (closed)
This MR introduces a project setting restrict_user_defined_variables
that when enabled allows only maintainers to set pipeline variables when triggering a pipeline. For example, via git push
options or when running a pipeline manually in the UI.
MR moved from https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/1134 since it's a feature instead.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino