Skip to content

Limit tribute autocomplete menu items to 100

Coung Ngo requested to merge cngo-limit-tribute-autocomplete-to-100 into master

What does this MR do?

We are in the process of migrating from atjs (deprecated and jQuery-based) to tribute for autocomplete under the feature flag tribute_autocomplete (defaulted to off).

When testing tribute autocomplete on gitlab.com, issue autocomplete renders tens of thousands of items in the autocomplete menu which freezes the UI for a couple of seconds. This is because tribute by default renders all list items. To improve performance, this MR adds a limit of 100 items, which is still more than the limit of 5 we currently have with atjs autocomplete.

Related epic: &4002

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports

Loading