Skip to content

Draft: Use whats_new_drawer instead of whats_new_dropdown

Phil Calder requested to merge 254186_consolidate_whats_new_dropdown into master

What does this MR do?

Consolidates the What's new feature under a single feature flag, rather than two.

TODO: remove unused feature flag YML (and add changelog?)

  • What's new is in the ? menu
  • when the flag is false, What's new will link to https://about.gitlab.com/releases/gitlab-com/
  • when the flag is true, the What's new link will open the What's new drawer
  • when the flag is true, the What's new feature can display a notification dot on the ? menu, and a count next to the What's new link (see gitlab-org/growth/engineering#5386 (closed) - currently uses local storage display-whats-new-notification-*

Note https://gitlab.com/gitlab-org/gitlab/-/issues/294184 will ensure code is moved to /ee where applicable

Screenshots (strongly suggested)

Screen_Shot_2021-01-18_at_2.04.31_PM

Screen_Shot_2021-01-18_at_2.05.55_PM

Screen_Shot_2021-01-18_at_2.08.10_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Phil Calder

Merge request reports

Loading