Skip to content

Allow for deletion of a rotation in OncallSchedules

What does this MR do?

A tiny MVC for #262863 (closed) where we hook up the frontend to the new backend code and allow for the Apollo cache to remove the deleted rotation from the grid.

🇺🇦 This feature is behind the feature flag oncall_schedules_mvc and the minimal license is GitLab Premium 👀

To check Enable the feature flag:

  • Navigate to Operations => On-call Schedules or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules.
  • Click "Add schedule on empty state"
  • Add a base schedule
  • You will see a new grid pre-populated with a set of fake rotations
  • You will be able to click the delete(trash icon) beside any rotation
  • A modal will appear that allows the deletion of that rotation
  • Currently, as we are using fake data, you will see a red alert inside the modal that states you cannot delete this non-existent item

Screenshots (strongly suggested)

No visual change.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #262863 (closed)

Merge request reports

Loading