Fix rotations_list_section_spec unmocked date
requested to merge 299142-broken-master-ee-spec-frontend-oncall_schedule-schedule-components into master
What does this MR do?
Background
In !51330 (merged) we added snapshot specs for the RotationsListSection component, this uses the CurrentDayIndicator underneath, the current day indicator is displayed when the current day falls within a specified date range.
Problem
The date range used in the mock data was effectively Jan 12 - Jan 19, today being Jan 19 caused the CurrentDayIndicator to stop appearing which broke the related snapshots
Solution
- Adds
useFakeDateto mock the current day for the specs - Minor reorganization of the specs to test the expected behaviour of the
CurrentDayIndicator
Screenshots (strongly suggested)
No visual changes
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #299142 (closed)
Edited by Ezekiel Kigbo