Add name validation to Terraform state model
What does this MR do?
Our terraform model includes a db index_terraform_states_on_project_id_and_name
. Also, our Terraform APIs are setup to find a Terraform state based on it's name.
We have setup Terraform to include a unique name, but we are missing the name
validation on the model.
This MR will:
- Add name validation to Terraform::State model
- Add fix to
services/terraform/remote_state_handler.rb
to handle name valiation
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #298703 (closed)
Edited by Emily Ring