Skip to content

Update styling not to use fit-content prop

Olena Horal-Koretska requested to merge 297502-update-styling into master

What does this MR do?

Updates Oncall schedule rotation styles not to use width: fit-content; as it was pointed out it is Working Draft of the specification yet gitlab-ui!1962 (comment 489054084) so until it is more stable the CSS was updated with a simpler solution.

🇺🇦 It is behind the feature flag oncall_schedules_mvc and the minimal license is GitLab Premium

👀 To check Enable feature flag=>Navigate to Operations/On-call schedule or direct link is your_project/-/oncall_schedules e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules

Then add schedule, after you'd be able to add rotations

👀 What to look for End date and Restrict to time intervals should be of the same size no matter the length of the timezone

🗒 If the timezone name would be very long - it will wrap to the next line, but in reality the list of timezones doesn't have such values

Screenshots (strongly suggested)

No visual changes expected

1 2 3
Screen_Shot_2021-01-20_at_17.29.13 Screen_Shot_2021-01-20_at_17.40.33 Screen_Shot_2021-01-20_at_17.40.14

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #297502 (closed)

Edited by Olena Horal-Koretska

Merge request reports

Loading