Allow user SSH public key endpoint to be publicly accessible again
What does this MR do?
Fixes the regression described at #296620 (closed).
When an instance's public visibility is restricted, we should still show the /<user>.keys endpoint without authentication. This matches with the API behavior of allowing /api/v4/:id/keys endpoint.
The behavior of the endpoint was inadvertently changed with !35507 (merged) because of the different way user is queried in the UsersController vs. KeysController.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team