Draft: Replace bootstrap tabs behavior with GitLab's
What does this MR do?
Replace bootstrap tabs behavior with GitLabs
- remove .nav-tabs class and data-toggle to remove bootstrap tabs usage
- create custom tabs interation handler to mimic bootstrap
TODO:
-
fix bug where refreshing on non-initial active tab loads the initial active tab instead of the newly selected active tab - actually, the current implementation does not do this, but the current implementation doesn't have a hash in it for each tab, so we can either
-
remove the hash from the url - OR
-
ensure that if we reload the page with a given hash, the tab the hash is pointing to is selected
-
- actually, the current implementation does not do this, but the current implementation doesn't have a hash in it for each tab, so we can either
-
maybe implement gl-tabs styles instead of relying on .gitlab-tabs
styling or that could be a v2,🤷 probably good to do it all at once -
test with many tabs -
add tests
Screenshots (strongly suggested)
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #297244 (closed)
Edited by Alexander Turinske