Skip to content

Get GITLAB_FEATURES from Project#licensed_features instead of Namespace#features (#5320)

Dylan Griffith requested to merge ee-5320-fix-gitlab-features-env-var into master

What does this MR do?

The CE + EE work combined fixes the GITLAB_FEATURES env variable for CI so that it takes project visibility into account. In the first iteration we just checked for features being available based on the namespace license but public projects should have all features available.

Are there points in the code the reviewer needs to double check?

CE Part of this work is in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18189

Are there any more license rules that need to be taken into account?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • [-] Documentation created/updated
  • [-] API support added
  • Tests added for this feature/bug
  • Review
    • [-] Has been reviewed by UX
    • [-] Has been reviewed by Frontend
    • Has been reviewed by Backend
    • [-] Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Edited by Grzegorz Bizon

Merge request reports

Loading