Skip to content

Clean up uniqueness validations for service type

What does this MR do?

  • Remove on: :create for project services, this can now always be validated after we've removed all duplicates.

  • Unify the validation syntax for all service types.

    • The queries are the same as before for project_id / group_id.
    • For template / instance the order of the WHERE conditions is swapped, but they can still use the same indexes as before.

Related to #207385 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller

Merge request reports

Loading