Convert Repo Compare to Vue
What does this MR do?
This MR is simply converting the compare revisions
into Vue. I did also convert the dropdown to use our PJ component GlDropdown
. Besides that, there should be NO noticeable UI/UX difference from our production.
MR | Changes |
---|---|
!52547 (merged) | Remove compare switcher |
Convert branch selection in Vue | |
TBD | Add repository dropdown |
TBD | Docs: Update docs |
Note: Yes you may notice the design responsiveness is not great (this matches our production); I will however address this in a follow-up ticket when I update this feature to match our new mock > #14615 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #14615 (closed)
Edited by Samantha Ming