Skip to content

Draft: Make `let_it_be(..., freeze: true)` the default

Peter Leitzen requested to merge pl-spec-let-it-be-frozen-by-default into master

What does this MR do?

Freezes all let_it_be by default to prevent state leakage across examples.

It seems that using let_it_be_with_{reload,refind} makes the objects unfrozen again:

project = Project.last
project.frozen? # => false
project.freeze
project.frozen? # => true
project.reload
project.frozen? # => false

It's because of https://api.rubyonrails.org/classes/ActiveRecord/Core.html#method-i-frozen-3F.

Refs #299822 (comment 493168376)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports

Loading