Skip to content

Abstract out details of policy_helper

Alexander Turinske requested to merge 300133-update-policy-helper into master

What does this MR do?

Abstract out details of policy_helper

  • move details into a private method to make #policy_details more readable
  • abstract out reusable test data

Screenshots (strongly suggested)

Everything is the same

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #300133 (closed)

Merge request reports

Loading