Skip to content

Migrate project settings to use GlToggle

Coung Ngo requested to merge cngo-migrate-project-settings-to-use-gl-toggle into master

What does this MR do?

This MR migrates the toggle in project settings to GlToggle. It also improves the two specs it touches to be more in line with our current frontend testing guidelines.

Related: &4135 (closed)

Screenshots (strongly suggested)

before after
Screenshot_2021-01-27_at_6.49.56_pm Screenshot_2021-01-27_at_6.57.54_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports

Loading