Make Danger warn when a feature flag is removed and title doesn't include required flags [RUN ALL RSPEC] [RUN AS-IF-FOSS]
requested to merge 299463-make-danger-warn-when-a-feature-flag-is-removed-and-title-doesn-t-include-run-all-rspec-run into master
What does this MR do?
Make Danger warn when a feature flag is removed and title doesn't include required flags [RUN ALL RSPEC] [RUN AS-IF-FOSS]
.
Additionally, Danger will update the MR title so that it includes [RUN ALL RSPEC] [RUN AS-IF-FOSS]
and start a new MR pipeline.
Screenshots (strongly suggested)
1. Danger updates the MR title
2. Danger starts a new MR pipeline
3. Danger leaves an information message
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #299463 (closed)
Edited by Rémy Coutable