Introduce a rendering limit for commit titles
What does this MR do?
We pass "full" commit titles through Banzai in just one place: Projects::RefsController#logs_tree (via Gitlab::TreeSummary). It is shown (truncated to 100 characters, with the rest in tooltips) on the repository file browser.
Permitting unlimited-length lines to be passed through banzai is a recipe for puma timeouts, so add a 1KiB limit to these, mirroring the 1MiB limit we added to commit descriptions.
We also clean up the omission string used (from unicode to ...) so it renders correctly in more places.
Finally, document both it and the pre-existing commit description limit.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #292039 (closed)
Closes #299079 (closed)