Add license check for full code quality report
What does this MR do?
Found via this slack thread (internal link)
This MR adds a license check for an existing feature: the full code quality report is a "GitLab Starter"/"GitLab Premium"-and-up feature
Context:
When we introduced the full code quality report, the code quality artifact was only downloadable with the required license (GitLab Starter and above), so we used the availability of the artifact as a quasi-license-check to determine whether to show the full code quality report for a pipeline.
Then when I moved the code quality MR widget to core, I made the artifact downloadable on GitLab Core so we could use it for the widget, but I didn't consider that it would also affect the quasi-license-check for the full code quality report.
Technical details:
This MR...
- adds
full_codequality_report
to the list ofEES_FEATURES
inlicense.rb
- checks that the project has the
full_codequality_report
before rendering the "Code Quality" pipeline tab - checks that the project has the
full_codequality_report
before rendering the contents of the "Code Quality" pipeline tab - adds a test case to make sure the tab won't show when unlicensed
Screenshots
There should be no visual changes, but here's the tab we're license-gating: |
---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Edited by Miranda Fluharty