Skip to content

Fix welcome page design on CE

Nicolas Dular requested to merge nicolasdular/fix-welcome-page into master

What does this MR do?

While trying out CE, I've noticed that the design of the welcome page is off. This MR fixes the problem.

The width for the welcome page card wasn't set since the style definition was in EE. Since the welcome page layout is also used for other steps, the margin: 0 set on the container div made the card not aligned in the middle of the page.

How to try it out

  1. gdk stop (if running)
  2. FOSS_ONLY=1 gdk start
  3. Signup as a new user. After you click on "Register", you will be redirected to the welcome page that you see in the screenshot below.

Screenshots (strongly suggested)

Before After
Screenshot_2021-02-03_at_17.35.09 Screenshot_2021-02-03_at_17.48.10

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading