Skip to content

Refactor sidebar detail row and spec

Payton Burdette requested to merge pb-resolve-tech-debt-sidebar-detail-row into master

What does this MR do?

  • Removes unused class
  • Refactors to use utility classes
  • Refactors spec to use Vue test utils

Code only change, does not warrant a changelog.

Related to: #300347 (closed)

Where is this change?

This change is on the job detail view sidebar.

Screenshots (strongly suggested)

before after
Screen_Shot_2021-02-04_at_3.37.21_PM Screen_Shot_2021-02-05_at_8.41.16_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette

Merge request reports

Loading