Skip to content

Migrate feature highlight to Vue

What does this MR do?

  1. It migrates the feature highlight feature from Vanilla JS / HAML to Vue.
  2. Fixes popover position bug (as a consequence of 1.)
  3. Popover adheres to Pajamas specs (as a consequence of 1. too)
  4. Bundle size reduction by only loading the feature highlight component when needed.

Delivery MRs

How to test?

  • You may have to clean up the UserCallout so the popover can appear. Run the following command on rails c
    > rails c
    > UserCallout.find_by(feature_name: 'gke_cluster_integration').delete
  • Open the following URL in your local environment: http://localhost:3000/h5bp/html5-boilerplate/-/metrics?environment=10.
  • You should see the popover as described in the screenshots above

Screenshots (strongly suggested)

Before After
Screen_Shot_2021-02-05_at_11.04.39_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #227259 (closed)

Edited by Enrique Alcántara

Merge request reports

Loading