Conver External HTTP's hashy query to query string
What does this MR do?
Closes #301009 (closed)
External HTTP performance bar consumes the event from request.external_http topic. The events in this topics are generated by the instrumenter. The instrumenter for Excon client HTTP library returns the query hash instead of full query string. That leads to this error:
This MR is to fix that error by converting the query hash to string. It's irony that the External HTTP View in peek already captures URI::Error, but still count not capture this kind of error. Therefore, I widen the error catching as well.
This is the first iteration to quick-fix the error. In the next iteration, Labkit::ExconPublisher should ensure that all the published params are URI-compatible.
Screenshots (strongly suggested)
It's a bug fix. After the fix, the web requests using Excon with Performance Bar enabled will work as normal
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team