Allow saving repository weights after a storage has been removed
What does this MR do?
Fixes #241752 (closed)
Previously if a storage was removed but the weight for that storage still existed in the database, the admin page would no longer allow updating any weights. This MR uses the same strategy as the admin API does, completely replace the entire hstore field on each update.
- Update project storage selection logic to include only currently configured storages.
- Switch from using
store_accessor
to using form helpers on the hstore viaOpenStruct
. This allows the entire hstore to be overwritten, removing any storages that are no longer present in the config.
Steps to reproduce (GDK)
Omnibus instructions are in the issue
- Add more storages in
gdk.yml
andgdk reconfigure && gdk restart
:gitaly: storage_count: 5
- Update repository storage weights:
- Remove storages in
gdk.yml
andgdk reconfigure && gdk restart
:gitaly: storage_count: 4
- Update repository storage weights:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by James Fargher