Use parseBoolean for canEdit when mounting iteration_select.vue
What does this MR do?
Fix 1
When user can't edit iteration, canEdit
data attribute should be parsed using parseBoolean
to prevent this error:
(parseBoolean
is already used elsewhere in mount_sidebar.js
)
Fix 2
We should have used .to_s
to convert can_edit_issuable
to string
in _sidebar.html.haml
.
(this is only noticeable once we start parsing canEdit
with parseBoolean
.)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by euko