Strip trailing whitespace from validation response
requested to merge philipcunningham-strip-newlines-from-http-response-in-dast-site-validation-321219 into master
What does this MR do?
this merge request strips trailing whitespace from response bodies before comparing them with tokens.
Why?
we got feedback that trailing whitespace was sometimes ending up in text files being used for dast site validation. the suspicion is that this is happening because users may be opening the text file and their editor is appending before saving. we think that this may happen enough to protect against it.
Related Issue(s)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham