Improve metrics generator
What does this MR do?
Improves metric definition generator
- Use consistent array format for tier and distribution
- Fill milestone value from
VERSION
file
There are no tests yet, I've had some difficulties to add the, there is a follow up issue
You can test with:
bundle exec rails generate gitlab:usage_metric_definition counts.issues.foo --ee --dir=license
Generator docs https://docs.gitlab.com/ee/development/usage_ping/metrics_dictionary.html
rails g gitlab:usage_metric_definition --help
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alina Mihaila