Skip to content

Fix(EoA Banner): add test coverage + log error

What does this MR do?

This MR adds feature tests to the EoA banner. For more context see the comment here: !52670 (comment 498787625)

Follow-up to this MR: !52670 (merged)

Screenshots (strongly suggested)

User Group
Screen_Shot_2021-01-26_at_19.31.06 Screen_Shot_2021-01-26_at_14.42.59

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

To test this out for groups

  • Run the following in bin/rails c
Feature.enable(:show_billing_eoa_banner)
group = Group.find_by_full_path('h5bp')
subscription = GitlabSubscription.where(namespace_id: group.id)[0]
subscription.update(hosted_plan_id: 1)
current_user = User.find_by(username: 'root')
group.add_owner(current_user.id)

To test this out for users

  • Run the following in bin/rails c
Feature.enable(:show_billing_eoa_banner)
current_user = User.find_by(username: 'root')
subscription = GitlabSubscription.where(namespace_id: current_user.namespace.id)[0]
subscription.update(hosted_plan_id: 1)

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #271523

Edited by Michael Lunøe

Merge request reports

Loading