Skip to content

Dynamic Link static security configuration Page [RUN AS-IF-FOSS]

Jannik Lehmann requested to merge jnnkl-static-sec-conf-dynamic-link into master

What does this MR do?

This MR solves #320906 (closed).

It implements conditional linking on the static Security Configuration Page, depending on whether the user has the Discover Security page available.

The conditions are:

  • They're on GitLab.com
  • They're viewing a project in a group/namespace they are an admin of
  • They're on any plan except Ultimate

If these conditions don't apply the upgrade page is rendered.

Screenshots (strongly suggested)

Screenshot_2021-02-15_at_15.34.36

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mark Florian

Merge request reports

Loading