Clean up active session
What does this MR do?
In the class responsible for active session handling was bunch of code with TO-DO remark and notes, that those parts are to be deleted in 13.7 milestone.
Since this is one of the places that uses crypto-helper class that was already problematic and I decided to clean those code before starting working on crypto-helper problem.
Method that was changed was only used in one place that was responsible for revoking session from user/settings page.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #321303 (closed)