Skip to content

Minor dependency cleanup

Lukas Eipert requested to merge leipert-minor-dependency-cleanup into master

What does this MR do?

  • Move four dependencies to be devDependencies

We don't use glob, jest-transform-graphql, miragejs or mock-apollo-client in production code. So let's move them to our dev dependencies.

  • Remove two unused top level dependencies
  1. brace-expansion seems to have been added in order to fix a vulnerability, this is not strictly necessary, as it requires a newer version in our yarn.lock file. Original commit: e6adc508
  2. fontawesome is unused
  • Remove unused pixelmatch dependency

We recently removed favicon specs from karma, which were the only ones utilizing the pixelmatch library.

See: !50530 (merged)

  • Update vulnerable dependencies
  • Update vulnerable dependency elliptic

See: https://www.npmjs.com/advisories/1547

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert

Merge request reports

Loading