Do not show button to resolve discussion opening an issue when issues are disabled or not visible to user
requested to merge 20917-do-not-show-button-to-resolve-discussion-opening-an-issue-when-issues-are-disabled-or-not into master
What does this MR do?
This MR simply makes resolve_with_issue_path
return nil
if project issues are disabled. This will prevent the bug in #20917 (closed) from happening.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #20917 (closed)
Edited by Gary Holtz